Add assembly redirects for cross version integration tests #451
+52
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: This is a topic of some discussion. We need to determine (generally) how extensions are going to work in a mixed v4/v5 scenario. Please let me know if you get blocked by this and we can discuss alternatives (like temporarily committing .msis built with v4). |
|
Thanks. I should be ok .. I'll skip adding cross-version integration tests until a decision has been made. |
chrisbednarski
force-pushed
the
feat/merge-test
branch
from
08db20d to
57b1171
Compare
|
rebased with develop. My two cents: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a few issues before I was able to build V4 and V5 test projects together.
A module merge test will follow, but I thought this might be handy in a separate commit, in case it needs to be undone for some reason later on.
nuget.configchange loadsWixToolset.*< v5 from nuget, but uses the local packages from the build folder for the v5 being built.<ProjectReference Include="**\*.wixproj" />inTestData.proj) and some of those projects are different versions.Before nuget.config change
Before assembly redirects were added
